[VFX/URP] Fix decal with overlay & scale #5401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URP implementation relies on screen scale & graphics api See https://github.com/Unity-Technologies/Graphics/blob/b468fa4627d191f06200a0f33df3d9cddee2c3f9/com.unity.render-pipelines.universal/ShaderLibrary/ShaderVariablesFunctions.hlsl#L347
This reverts commit b8bfebb.
…tly overlay when there is a renderScale)
In discussion with @ludovic-theobald about this behavior.
com.unity.render-pipelines.high-definition/Editor/VFXGraph/Shaders/VFXDecal.template
Show resolved
Hide resolved
There is probably something wrong in SetPerCameraShaderVariables
# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
ludovic-theobald
approved these changes
Oct 4, 2021
aleksandrasdzikia
approved these changes
Oct 7, 2021
VitaVFX
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
Thank you for the fix, Paul. Couldn't find any outstanding issues related to PR. 🟢
URP: Retested Render Scale, tweaked various camera settings, built standalone
HDRP: Checked Transparent Render Queue, tweaked Dynamic Resolution settings, built standalone (used HDRP decal output for tests)
|
Double check at 19b5a36 the behavior is still valid: |
julienf-unity
approved these changes
Nov 23, 2021
PaulDemeulenaere
added a commit
that referenced
this pull request
Dec 13, 2021
* Use abstraction to compute screen space uv The URP implementation relies on screen scale & graphics api See https://github.com/Unity-Technologies/Graphics/blob/b468fa4627d191f06200a0f33df3d9cddee2c3f9/com.unity.render-pipelines.universal/ShaderLibrary/ShaderVariablesFunctions.hlsl#L347 * *Add Graphics Test * Experiment : Revert Pass.template from #4601 * Enable GraphicTest & add RenderScale * Revert "Experiment : Revert Pass.template from #4601" This reverts commit b8bfebb. * Fix overlay decal * *Update test Scene * *Remove 104_Decal_And_SoftParticle (Graphic Test can't capture correctly overlay when there is a renderScale) * Remove unexpected "if (_ProjectionParams.x < 0)" & Update ChangeLog In discussion with @ludovic-theobald about this behavior. * Restore actually correct _ProjectionParams.x test There is probably something wrong in SetPerCameraShaderVariables * Revert change in URP * Minor: Apply suggestion from @julienf #5401 (comment) * Unexpected change in changelog * Unexpected modification in CHANGELOG.md * Fix changelog ordering Co-authored-by: julienf-unity <julienf@unity3D.com> # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
sebastienlagarde
pushed a commit
that referenced
this pull request
Jan 13, 2022
* Use abstraction to compute screen space uv The URP implementation relies on screen scale & graphics api See https://github.com/Unity-Technologies/Graphics/blob/b468fa4627d191f06200a0f33df3d9cddee2c3f9/com.unity.render-pipelines.universal/ShaderLibrary/ShaderVariablesFunctions.hlsl#L347 * *Add Graphics Test * Experiment : Revert Pass.template from #4601 * Enable GraphicTest & add RenderScale * Revert "Experiment : Revert Pass.template from #4601" This reverts commit b8bfebb. * Fix overlay decal * *Update test Scene * *Remove 104_Decal_And_SoftParticle (Graphic Test can't capture correctly overlay when there is a renderScale) * Remove unexpected "if (_ProjectionParams.x < 0)" & Update ChangeLog In discussion with @ludovic-theobald about this behavior. * Restore actually correct _ProjectionParams.x test There is probably something wrong in SetPerCameraShaderVariables * Revert change in URP * Minor: Apply suggestion from @julienf #5401 (comment) * Unexpected change in changelog * Unexpected modification in CHANGELOG.md * Fix changelog ordering Co-authored-by: julienf-unity <julienf@unity3D.com> # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix regression (not logged) on overlay introduced by [VFX] HDRP Decal Output #4601 (see this change : 776655f)We opened a dedicated fogbugz for this URP issue https://fogbugz.unity3d.com/f/cases/1368762/=> Fixed 🟢Testing status
I pushed the debug scene.
Before
After
However, I can't use this scene for graphicTest because the framework doesn't correctly save the result when there is an overlay :
⚠️ The overlay fix has been reverted and will be independently fixed. ⚠️
Also, testing manually with renderscale update modification:
Comments to reviewers
This PR follows up with several fixes done in this change : #4733
@Unity-Technologies/gfx-qa-vfx This change also impacts newly introduced HDRP decals but, afaik, HDRP is never using rendering without offscreen texture.