Skip to content

Conversation

debaetsd
Copy link
Contributor

Backport to 10.x.x
master PR: #5393

This PR fixes incorrect SRP batcher incompatibility when sampling a PVT inside a subgraph.
This was due to a serialization bug wrt VT property flags

Checklist for PR maker

  • Have you updated the changelog? Each package has a CHANGELOG.md file.

@debaetsd debaetsd requested a review from cdxntchou August 19, 2021 15:01
@debaetsd debaetsd requested a review from a team as a code owner August 19, 2021 15:01
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@debaetsd debaetsd changed the title Fixed a serialization bug wrt PVT property flags when using subgraphs [10.x.x] Fixed a serialization bug wrt PVT property flags when using subgraphs Aug 31, 2021
Copy link
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@debaetsd debaetsd merged commit c24a24f into 10.x.x/release Sep 1, 2021
@debaetsd debaetsd deleted the 10.x.x/sg/fix-pvt-subgraph branch September 1, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants