Skip to content

[HDRP][DXR] Fix for punctual and directional ray traced shadow broken temporal denoiser #5417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2021
Merged

[HDRP][DXR] Fix for punctual and directional ray traced shadow broken temporal denoiser #5417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d8223a
Fixed a regression that broke punctual and directional raytraced shad…
anisunity Sep 6, 2021
5dbfc36
Merge branch 'master' into HDRP/fix-1360132
sebastienlagarde Sep 6, 2021
e91f570
Merge branch 'master' into HDRP/fix-1360132
sebastienlagarde Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed specular occlusion sharpness and over darkening at grazing angles.
- Fixed edge bleeding when rendering volumetric clouds.
- Fixed the performance of the volumetric clouds in non-local mode when large occluders are on screen.
- Fixed a regression that broke punctual and directional raytraced shadows temporal denoiser (case 1360132).

### Changed
- Visual Environment ambient mode is now Dynamic by default.
Expand Down
3 changes: 3 additions & 0 deletions ...ty.render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/HDTemporalFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,9 @@ public TemporalDenoiserArrayOutputData DenoiseBuffer(RenderGraph renderGraph, HD
int numTilesX = (data.texWidth + (tfTileSize - 1)) / tfTileSize;
int numTilesY = (data.texHeight + (tfTileSize - 1)) / tfTileSize;

// This variant of the function only supports full resolution
CoreUtils.SetKeyword(ctx.cmd, "FULL_RESOLUTION_INPUT", true);

// Now that we have validated our history, let's accumulate
ctx.cmd.SetComputeTextureParam(data.temporalFilterCS, data.temporalAccKernel, HDShaderIDs._DenoiseInputTexture, data.noisyBuffer);
ctx.cmd.SetComputeTextureParam(data.temporalFilterCS, data.temporalAccKernel, HDShaderIDs._HistoryBuffer, data.historyBuffer);
Expand Down