-
Notifications
You must be signed in to change notification settings - Fork 855
Make shadow cascade debug colors match editor UI colors. #5430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make shadow cascade debug colors match editor UI colors. #5430
Conversation
- Fix apparent UI color typo.
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP URP SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
good catch, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Developer already tested this in URP and HDRP, approving without additional testing
Yamato against 21.2 is broken, so running PR jobs against latest green (cb3b74b20e592145e75fb03993f7a23e2c09e03a) now. EDIT: rerunning jobs after Yamato is back up and HDRP test images are fixed: |
@sebastienlagarde this should be good to go. Fixed HDRP test images for a test that used cascade debug mode, URP doesn't have a corresponding test. Failures in both test suites but couldn't spot anything that would seem related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch for the typo. It should be me, sorry.
Purpose of this PR
Making sure Shadow Cascade debug colors in the viewport match the ones in the editor UI. The colors are not 100% the same in order to have better contrast in the viewport under varying lighting conditions.
URP before:

URP after:

HDRP before:

HDRP after:

Also fixed apparent typo resulting in too bright color in the UI:


before:
after:
Testing status
Checked URP & HDRP look as expected.