Skip to content

[HDRP][DXR] Removed work-around on vertex color in ray tracing, after changes to the engine #5445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2021
Merged

[HDRP][DXR] Removed work-around on vertex color in ray tracing, after changes to the engine #5445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2998ab
Removed temp fix for vertex color in ray tracing.
eturquin Aug 25, 2021
0277182
Merge branch 'master' into hd/rt_vertex_color
eturquin Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...nes.high-definition/Runtime/RenderPipeline/Raytracing/Shaders/RaytracingIntersection.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,6 @@ void FetchIntersectionVertex(uint vertexIndex, out IntersectionVertex outVertex)
#ifdef ATTRIBUTES_NEED_COLOR
outVertex.color = UnityRayTracingFetchVertexAttribute4(vertexIndex, kVertexAttributeColor);

// We want to default to white in case there is no specified color, to match the raster behaviour
// FIXME: This could be addressed in UnityRayTracingFetchVertexAttribute4(), but until then we use this workaround
if (!any(outVertex.color))
outVertex.color = 1.0;

#else
outVertex.color = 0.0;
#endif
Expand Down