Skip to content

Conversation

remi-chapelain
Copy link
Contributor

Purpose of this PR

This PR fixes a really simple and cosmetic issue on the lens flare sample.
On squared resolutions or portrait one, the lens flare sample instructions text wasn't staying on the bottom left because of how the anchor of the text was setup.
On classic landscape resolutions (like 1080p), the issue does not repro because it was setup using this ratio most probably.
Here's 3 gifs with resolutions to show the problem.

Classic 1080p landscape
1080p_Landscape

Square 2048px
Squared

1080p Portrait
Portrait


Testing status

Tried reimporting the sample after and changed to multiple resolutions to verify that the instructions were staying on the bottom left. ✔️

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Aug 26, 2021
@remi-chapelain remi-chapelain requested review from a team and sebastienlagarde August 26, 2021 13:41
@remi-chapelain remi-chapelain marked this pull request as ready for review August 26, 2021 13:42
Copy link
Contributor

@iM0ve iM0ve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sebastienlagarde sebastienlagarde merged commit d9d26ab into master Aug 26, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/lens-flare-sample-instructions-anchor branch August 26, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants