[VFX] Fix soft particles (to 2021.1) #5453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update changelog # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md * Different depth computation for orthographic camera # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md * Restore change from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/211/commits/8169e083d9b68114bd7a248ebba1dfba38fca3f5 But using URP specific helper "LinearDepthToEyeDepth" * FIx issue 1330697 Correctly applying the flip-y when appropriate while sampling * Fix scaling using dedicated URP helper It's simpler than reimplement the space transform and equivalent * Update com.unity.render-pipelines.universal/Runtime/VFXGraph/Shaders/VFXCommon.hlsl Fix comment Co-authored-by: Elvar Örn Unnþórsson <ellioman@ellioman.com> * Fix issue #4733 (comment) Remove VFXLinearEyeDepth & VFXLinearEyeDepthOrthographic from the SRP specific implementation Synchronize implementation for VFXLinearEyeDepth in VFXCommonCompute.hlsl (not used anyway) TODO : Move LinearDepthToEyeDepth in core for 21.2 Co-authored-by: Ludovic Theobald <ludovic.theobald@unity3d.com> Co-authored-by: Elvar Örn Unnþórsson <ellioman@ellioman.com> # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md # com.unity.render-pipelines.universal/Runtime/VFXGraph/Shaders/VFXCommon.hlsl # com.unity.visualeffectgraph/CHANGELOG.md
Apply VFXSampleDepth for URP on the correct file
ludovic-theobald
approved these changes
Aug 27, 2021
ellioman
approved these changes
Sep 6, 2021
erikabar
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Backport of #4733
Testing status
Awaiting for Yamato ⏳
Comments to reviewers
N/A