Skip to content

Conversation

Seongdae
Copy link
Contributor

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

To fix flickering issues in screen space shadows with deferred rendering mode


Testing status


Comments to reviewers

@Seongdae Seongdae requested review from ellioman and phi-lira August 30, 2021 05:17
@Seongdae Seongdae self-assigned this Aug 30, 2021
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@Seongdae Seongdae changed the title Urp/fix s shadows in deferred Fix an issues of flickering in URP's deferred rendering mode Aug 30, 2021
@ellioman ellioman requested a review from a team September 2, 2021 08:03
@ellioman ellioman removed the request for review from phi-lira September 6, 2021 11:49
@Seongdae Seongdae requested a review from ellioman September 7, 2021 01:22
@ellioman ellioman marked this pull request as ready for review September 7, 2021 06:53
@ellioman ellioman requested a review from a team as a code owner September 7, 2021 06:53
Copy link
Contributor

@eh-unity eh-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Seongdae Seongdae added the ready-to-merge Add this tag whenever your PR is ready to be merged. i.e, non draft, all reviewers approved, ABV label Sep 8, 2021
@Seongdae Seongdae merged commit 0f853b2 into master Sep 8, 2021
@Seongdae Seongdae deleted the urp/fixSShadowsInDeferred branch September 8, 2021 01:30
@Seongdae Seongdae mentioned this pull request Sep 8, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Add this tag whenever your PR is ready to be merged. i.e, non draft, all reviewers approved, ABV universal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants