Merge shape offset parameters #5469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-de-tocqueville
requested review from
remi-chapelain and
sebastienlagarde
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
sebastienlagarde
approved these changes
Aug 30, 2021
|
please, launch yamato on trunk (it works) |
sebastienlagarde
added a commit
that referenced
this pull request
Sep 3, 2021
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
fix https://fogbugz.unity3d.com/f/cases/1358715
If one of the three shape offset parameters were overriden, the new parameter is marked overriden. Otherwise it still copies the values but is not overriden.
Replace the three shapeOffsetX, shapeOffsetY and shapeOffsetZ by one parameter shapeOffset, which causes an API change but I believe it's not problematic
Testing status
Tested migration of a volume profile
Comments to reviewers
@anisunity for awareness