Skip to content

Allow negative wind speed parameter #5470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Allow negative wind speed parameter #5470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed lens flare not rendering correctly with TAAU or DLSS.
- Fixed case where the SceneView don't refresh when using LightExplorer with a running and Paused game (1354129)
- Fixed wrong ordering in FrameSettings (Normalize Reflection Probes)
- Allow negative wind speed parameter.

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.high-definition/Editor/Sky/VisualEnvironmentEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ public override bool OnGUI(SerializedDataParameter parameter, GUIContent title)
if (!LocalWindParameterDrawer.BeginGUI(out var rect, title, parameter, mode))
{
var value = parameter.value.FindPropertyRelative("customValue");
value.floatValue = Mathf.Max(EditorGUI.FloatField(rect, title, value.floatValue), 0.0f);
value.floatValue = EditorGUI.FloatField(rect, title, value.floatValue);
}
LocalWindParameterDrawer.EndGUI(mode);

Expand Down
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.high-definition/Runtime/Sky/VisualEnvironment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public sealed class VisualEnvironment : VolumeComponent
[Header("Wind")]
public ClampedFloatParameter windOrientation = new ClampedFloatParameter(0.0f, 0.0f, 360.0f);
/// <summary>Controls the global wind speed in kilometers per hour.</summary>
public MinFloatParameter windSpeed = new MinFloatParameter(100.0f, 0.0f);
public FloatParameter windSpeed = new FloatParameter(100.0f);

// Deprecated, kept for migration
[SerializeField]
Expand Down