Skip to content

Conversation

sarah-welton
Copy link
Contributor

For ticket DOC-3319/GSG-543

OG PR: https://github.com/Unity-Technologies/Graphics/pull/3620/files

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • [X ] Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • [X ] Have you updated the changelog? Each package has a CHANGELOG.md file.
  • [X ] Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • [n/a ] Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Solving the issue identified in DOC-3319 RE: missed backport on previous SG ticket/PR.


Testing status

Describe what manual/automated tests were performed for this PR
n/a


Comments to reviewers

Notes for the reviewers you have assigned.

@sarah-welton sarah-welton added Shader Graph Docs ready-to-merge Add this tag whenever your PR is ready to be merged. i.e, non draft, all reviewers approved, ABV labels Aug 30, 2021
@sarah-welton sarah-welton requested a review from a team as a code owner August 30, 2021 21:07
Copy link
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarah-welton sarah-welton merged commit 7656a5f into 2021.1/staging Sep 1, 2021
@sarah-welton sarah-welton deleted the 2021.1-backport-sg-doc-2627 branch September 1, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs ready-to-merge Add this tag whenever your PR is ready to be merged. i.e, non draft, all reviewers approved, ABV Shader Graph

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants