Skip to content

Conversation

sebastienlagarde
Copy link
Contributor

Purpose of this PR

Bump version to 13.0.0


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_2021.2

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_2021.2

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/.yamato%252F_abv.yml%2523all_project_ci_2021.2
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@kivistikliis
Copy link
Contributor

kivistikliis commented Aug 31, 2021

Thanks! Looking at the previous bump to 12, com.unity.testing.visualeffectgraph and com.unity.testing.graphics-performance seem to be forgotten. I'm not sure about the rest of the com.unity.testing.* packages. Also, is the bump to 0a7 not 0a1 intended?

@sebastienlagarde
Copy link
Contributor Author

sebastienlagarde commented Aug 31, 2021

Thanks! Looking at the previous bump to 12, com.unity.testing.visualeffectgraph and com.unity.testing.graphics-performance seem to be forgotten. I'm not sure about the rest of the com.unity.testing.* packages. Also, is the bump to 0a7 not 0a1 intended?

good catch, fixed

'm not sure about the rest of the com.unity.testing.* packages.

not required

@sophiaaar sophiaaar marked this pull request as ready for review September 1, 2021 09:09
@sophiaaar sophiaaar requested review from a team as code owners September 1, 2021 09:09
@sophiaaar sophiaaar merged commit 57de3e2 into master Sep 1, 2021
@sophiaaar sophiaaar deleted the srp/bump-version-to-13 branch September 1, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants