Skip to content

Conversation

alelievr
Copy link
Member

Purpose of this PR

Add esc control to release the cursor when entering play mode in the template of HDRP.

https://forum.unity.com/threads/hdrp-template-esc-clicking-outside-of-viewport-doesnt-unfocus.1130944/


Testing status

Tested that the escape key and right/left click works as intended to respectively release and attach the focus:

With the new InputSystem:

MouseFocus.mp4

With the old one:

MouseFocusOld.mp4

@alelievr alelievr requested review from a team and sebastienlagarde August 31, 2021 15:30
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Aug 31, 2021
@alelievr alelievr marked this pull request as ready for review August 31, 2021 16:26
Copy link
Contributor

@RemyUnity RemyUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the video showcase, LGTM 🟢

@sebastienlagarde sebastienlagarde merged commit 8b10aea into master Sep 1, 2021
@sebastienlagarde sebastienlagarde deleted the hd/fix/camera-with-look-focus-issues branch September 1, 2021 09:46
sebastienlagarde pushed a commit that referenced this pull request Sep 3, 2021
* Fixed impossibility to release the cursor in the template.

* Updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants