Skip to content

Conversation

MilanAssuied
Copy link

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • [N\A] Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • [N\A] Have you updated the changelog? Each package has a CHANGELOG.md file.
  • [N\A] Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • [N\A] Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

This PR modify package version for packages that were modified for sensorSDK.

This change will help identify sensorsdk custom version of the graphics package
It will also avoid conflicts with existing packages with the same version.

The semantic versioning is respected.

This PR is meant to be merged in SensorSDK2021.1 branch, not in master.


Testing status

No tests are necessary


Comments to reviewers

Only the concerned packaged.json files are modified

This change will help identify sensorsdk custom version of the graphics package
It will also avoid conflicts with existing packages with the same version
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Unity SRP repo!
Please make sure to fill out the PR template as best you can to give reviewers as much information as possible.
If you have any questions (and you are a Unity employee) go to "#devs-renderpipe"

@MilanAssuied MilanAssuied merged commit b2decc7 into SensorSDK2021.1 Sep 1, 2021
@MilanAssuied MilanAssuied deleted the updateCustomGraphicsPackageVersion branch September 1, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants