Fixed partly qualified UITK controls types in com.unity.shadergraph IdentifierField #5492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Remove partly qualified UI Toolkit controls types in
IdentifierField
. These types were moved fromUnityEditor.UIElements
toUnityEngine.UIElements
and the ScriptUpdater is having a hard time dealing with partly qualified moved types.Another solution was to fully qualify the types, but this would have broken the package for older versions, where the types are still in
UnityEditor.UIElements
Testing status
Opening projects using
com.unity.shadergraph
, which would hang while importing without the fix.Previously ran full ABV pipeline against trunk and errors look like instabilities (timeouts and errors unrelated to my changes which are isolated in com.unity.shadergraph).
The errors reported in Shader Graph tests are false errors and are also happening on the master branch here.