Skip to content

Conversation

axel-dubillet
Copy link
Contributor

@axel-dubillet axel-dubillet commented Aug 31, 2021

Purpose of this PR

Remove partly qualified UI Toolkit controls types in IdentifierField. These types were moved from UnityEditor.UIElements to UnityEngine.UIElements and the ScriptUpdater is having a hard time dealing with partly qualified moved types.

Another solution was to fully qualify the types, but this would have broken the package for older versions, where the types are still in UnityEditor.UIElements


Testing status

Opening projects using com.unity.shadergraph, which would hang while importing without the fix.

Previously ran full ABV pipeline against trunk and errors look like instabilities (timeouts and errors unrelated to my changes which are isolated in com.unity.shadergraph).

The errors reported in Shader Graph tests are false errors and are also happening on the master branch here.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@axel-dubillet axel-dubillet marked this pull request as ready for review September 7, 2021 13:42
@axel-dubillet axel-dubillet requested a review from a team as a code owner September 7, 2021 13:42
@axel-dubillet axel-dubillet self-assigned this Sep 7, 2021
@theopnv
Copy link
Contributor

theopnv commented Sep 9, 2021

Removing myself from reviewers as I have no knowledge of the actual code. I'm still subscribed to the PR to keep an eye on it.

@theopnv theopnv removed their request for review September 9, 2021 11:17
@axel-dubillet axel-dubillet marked this pull request as draft September 9, 2021 14:45
@axel-dubillet axel-dubillet marked this pull request as ready for review September 10, 2021 13:36
Copy link
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would like to see CI run on a trunk pipeline before this gets merged.

@jessebarker jessebarker merged commit d9f8554 into master Sep 13, 2021
@jessebarker jessebarker deleted the sg/fix/identifierfield-uitktypes branch September 13, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants