[VFX] Update Test Case Filter #5493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to the usage of 08b03824843e33840a03794c433c3cef (VFXLitSphereOutput.cs)
This was referenced Sep 1, 2021
sebastienlagarde
approved these changes
Sep 1, 2021
sebastienlagarde
deleted the
vfx/test/exclude-platform-concerned-by-1353315
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Filters out platform where this fogbugz which causes an issue :
Shader error in 'Hidden/VFX/30_PositionOnSDF/System/Output Particle HDRP Lit Sphere': Interpolation mode for PS input position must be linear_noperspective_centroid or linear_noperspective_sample when outputting oDepthGE or oDepthLE and not running at sample frequency (which is forced by inputting SV_SampleIndex or declaring an input linear_sample or linear_noperspective_sample)Check this usage : https://github.com/Unity-Technologies/Graphics/search?q=08b03824843e33840a03794c433c3cef&type=
Testing status
Launching VFX_HDRP build in private: https://yamato.cds.internal.unity3d.com/jobs/339-ScriptableRenderPipelinePrivate/tree/master/.yamato%252Fall-vfx_hdrp.yml%2523VFX_HDRP_trunk/8469261/job/full-pipeline
I used this result to update
vfx/staging: https://github.cds.internal.unity3d.com/unity/ScriptableRenderPipelinePrivate/pull/217/commits/c701e38e6bfc4ab0622334be50715458d2ddbb0dComments to reviewers
It has to be backported in 21.1 & 20.3