updated macos reference images for VT tests #5498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o has issues on Metal)
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
sebastienlagarde
approved these changes
Sep 1, 2021
sebastienlagarde
pushed a commit
that referenced
this pull request
Sep 3, 2021
…o has issues on Metal) (#5498) Co-authored-by: Dieter De Baets <dieter.baets@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR updates MacOS reference images for the virtual texturing test.
This is done as a work around for issues when using inline sampler that enable anisotropic filtering (bug on the Apple driver side, submitted as rdar://78565177)
Testing status
OSX metal tests are passing now: https://unity-ci.cds.internal.unity3d.com/job/8461503
Comments to reviewers
I did not update the test itself to make it more obvious what exactly is happening (as discussed on Slack earlier). Updating the test itself would require new reference images for all backends while this PR simply unblocks the Metal tests. The will be updated in a later PR.