Skip to content

Conversation

kivistikliis
Copy link
Contributor

@kivistikliis kivistikliis commented Sep 1, 2021


Purpose of this PR

  • Removes adding a redundant unknown tag, if any pattern from any log is matched (except for successful-retry)
  • Overwrites matched pattern conclusion (which is usually failure) to be success for all successful-retries
  • Enforces having either successful-retry or instability tag, never both (having both would complicate distinguishing between successful retries, failed instabilities, and failed retries which are not instabilities. Refer to docs for more elaborate explanation)
  • Some other smaller rewrites

Testing status

Tested locally on several execution logs, as well as the new ones from this and this job, which brought these issues to attention.


Comments to reviewers

This is properly tested via Yamato, but as instabilities occur by random, the best way is to investigate the output after nightlies.

@kivistikliis kivistikliis marked this pull request as ready for review September 1, 2021 15:44
@kivistikliis kivistikliis requested a review from a team as a code owner September 1, 2021 15:44
@kivistikliis
Copy link
Contributor Author

Merging without explicit approval, as this was discussed and approved internally.

@kivistikliis kivistikliis merged commit 1ee6467 into master Sep 1, 2021
@kivistikliis kivistikliis deleted the yamato/instability-fix branch September 1, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant