Fix instability detection tagging #5503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
unknown
tag, if any pattern from any log is matched (except for successful-retry)failure
) to besuccess
for all successful-retriessuccessful-retry
orinstability
tag, never both (having both would complicate distinguishing between successful retries, failed instabilities, and failed retries which are not instabilities. Refer to docs for more elaborate explanation)Testing status
Tested locally on several execution logs, as well as the new ones from this and this job, which brought these issues to attention.
Comments to reviewers
This is properly tested via Yamato, but as instabilities occur by random, the best way is to investigate the output after nightlies.