Skip to content

Conversation

julienamsellem
Copy link
Contributor

Purpose of this PR

https://fogbugz.unity3d.com/f/cases/1340654/

When a tooltip in a subgraph output property spans on multiple lines text cannot be selected properly
OutputTooltip


Testing status

Only tested the scenario described in the fogbugz


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@VitaVFX
Copy link

VitaVFX commented Sep 1, 2021

Looking good! Tested:
VFX Graph, Subgraph, Subgraph Block, Subgraph block operator
Selecting text, selecting text using shortcuts, copy-paste selected text, insert some text, delete text. 🟢

@VitaVFX VitaVFX requested review from VitaVFX and removed request for a team September 1, 2021 19:13
@julienamsellem julienamsellem marked this pull request as ready for review September 3, 2021 12:32
Copy link
Contributor

@iTris666 iTris666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienamsellem julienamsellem merged commit 370fcc1 into master Sep 8, 2021
@julienamsellem julienamsellem deleted the vfx/fix/1340654-multiline-tooltip-output-properties branch September 8, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants