-
Notifications
You must be signed in to change notification settings - Fork 855
New APV workflow backend to remove need for ProbeReferenceVolume component from user side #5511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit a92bf42.
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
…onent from user side (#5511) * Create hidden per scene data * Start using new mode in baking workflow (Need to fix the tmp send data) * Remove loading/removal from authoring * Need to switch branch, move profile data to asset * Almost completely get rid of baking reference volume * remove baking ref from realtime subdiv (but not working :p) * Revert "remove baking ref from realtime subdiv (but not working :p)" This reverts commit a92bf42. * Remove all probe ref volume authroing from baking, yay! * Moving draw gizmo away and remove all reference of authoring from baking * Make sure baking profile is available if required during non baking * Load profile info from the asset * Fix dilation refresh * remove some other things * remove asset * Small rename * Move field inside EDITOR tags * Fix issue when no profile is ever loaded (i.e. first time a project is loaded) * guards
This PR is a refactor of how the workflow for APV works so that we can move away from the ProbeReferenceVolume component workflow.
Starting with the TL;DR: Essentially now the ProbeReferenceVolume component is purely a UX to input values, but they are now sent immediately to a centralized system that handles all the data. Meaning that if we have a UX somewhere else to input data (@alelievr is on the frontend now) we don't need the probe reference volume component.
A bit of a longer: