Skip to content

Conversation

FrancescoC-unity
Copy link
Contributor

This PR is a refactor of how the workflow for APV works so that we can move away from the ProbeReferenceVolume component workflow.

Starting with the TL;DR: Essentially now the ProbeReferenceVolume component is purely a UX to input values, but they are now sent immediately to a centralized system that handles all the data. Meaning that if we have a UX somewhere else to input data (@alelievr is on the frontend now) we don't need the probe reference volume component.

A bit of a longer:

  • Now every scene with a probe volume in it will have a completely hidden component created. This will own a bunch of assets, one per state (concept of state not here yet).
  • This component is going to queue and unqueue assets to be loaded, somewhat similarly to what the authoring component was doing before.
  • The profile is now a completely editor only concept, it doesn't need to be loaded at runtime and everything that is needed at runtime is stored on the asset itself.
  • The baking settings and profile are serialized for editor usage in a centralized asset indexed with Scene GUID.
  • Everything that was using the authoring (ProbeReferenceVolume) component is now not using it at all, so as soon as we have UX for user to input data, the backend is ready.

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the SRP label Sep 2, 2021
@JulienIgnace-Unity JulienIgnace-Unity merged commit 2257418 into master Sep 3, 2021
@JulienIgnace-Unity JulienIgnace-Unity deleted the HDRP/new-apv-workflow-backend branch September 3, 2021 07:52
sebastienlagarde pushed a commit that referenced this pull request Sep 3, 2021
…onent from user side (#5511)

* Create hidden per scene data

* Start using new mode in baking workflow (Need to fix the tmp send data)

* Remove loading/removal from authoring

* Need to switch branch, move profile data to asset

* Almost completely get rid of baking reference volume

* remove baking ref from realtime subdiv (but not working :p)

* Revert "remove baking ref from realtime subdiv (but not working :p)"

This reverts commit a92bf42.

* Remove all probe ref volume authroing from baking, yay!

* Moving draw gizmo away and remove all reference of authoring from baking

* Make sure baking profile is available if required during non baking

* Load profile info from the asset

* Fix dilation refresh

* remove some other things

* remove asset

* Small rename

* Move field inside EDITOR tags

* Fix issue when no profile is ever loaded (i.e. first time a project is loaded)

* guards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants