Skip to content

Vfx/fix/1327623 vfx recompiles for no change #5518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 13, 2021
Merged

Vfx/fix/1327623 vfx recompiles for no change #5518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d842c0a
Value comparison was not working because we are comparing objects
julienamsellem Sep 2, 2021
9df7e4e
Updated changelog
julienamsellem Sep 2, 2021
b353c62
Merge branch 'master' into vfx/fix/1327623-vfx-recompiles-for-no-change
julienamsellem Sep 9, 2021
85140ad
NRE could happen if the model's current value is null
julienamsellem Sep 9, 2021
dd5fbc8
Merge remote-tracking branch 'origin/vfx/fix/1327623-vfx-recompiles-f…
julienamsellem Sep 9, 2021
7543c18
Moved changelog entry from v12 to v13
julienamsellem Sep 13, 2021
123f914
Merge branch 'master' into vfx/fix/1327623-vfx-recompiles-for-no-change
julienamsellem Sep 13, 2021
fd7b46d
Merge branch 'master' into vfx/fix/1327623-vfx-recompiles-for-no-change
julienamsellem Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.visualeffectgraph/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Unexpected compilation error while modifying ShaderGraph exposed properties [Case 1361601](https://issuetracker.unity3d.com/product/unity/issues/guid/1361601/)
- Compilation issue while using new SG integration and SampleTexture/SampleMesh [Case 1359391](https://issuetracker.unity3d.com/product/unity/issues/guid/1359391/)
- Prevent VFX Graph compilation each time a property's min/max value is changed
- Prevent vfx re-compilation in some cases when a value has not changed

## [12.0.0] - 2021-01-11
### Added
Expand Down
2 changes: 1 addition & 1 deletion com.unity.visualeffectgraph/Editor/Models/VFXModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ private bool SetSettingValueAndReturnIfChanged(string name, object value)
}

var currentValue = setting.value;
if (currentValue != value)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variables are of type object which leads to reference comparison instead of value comparison.

if (!currentValue?.Equals(value) ?? value != null)
{
setting.field.SetValue(setting.instance, value);
OnSettingModified(setting);
Expand Down