Skip to content

[Quality Audit] Make MenuItem dynamically hiddeable for LookDev and RenderGraphWindow [OnHold] #5519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

[Quality Audit] Make MenuItem dynamically hiddeable for LookDev and RenderGraphWindow [OnHold] #5519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5d5c01c
Add hiddable MenuItem for SRP
RSlysz Sep 2, 2021
70b46da
Update CHANGELOG.md
RSlysz Sep 2, 2021
45cce3e
Add support for built-in as null type
RSlysz Sep 2, 2021
36e7afb
Add documentation
RSlysz Sep 2, 2021
2b22818
Update com.unity.render-pipelines.core/Editor/Utilities/MenuUtilities.cs
RSlysz Sep 2, 2021
a463c74
Update com.unity.render-pipelines.core/Editor/Utilities/MenuUtilities.cs
RSlysz Sep 2, 2021
5da8a60
Update com.unity.render-pipelines.core/Editor/Utilities/MenuUtilities.cs
RSlysz Sep 2, 2021
64fc593
Merge branch 'srpcore/qualityaudit/menuitem-dynamically-hiddeable' of…
RSlysz Sep 2, 2021
dcbf65d
Add feedbacks on naming
RSlysz Sep 2, 2021
538447e
Fix name
RSlysz Sep 2, 2021
6657696
Move LookDev and RenderGraph mechanisme into CoreRP
RSlysz Sep 7, 2021
85899d3
Remove Unused MenuItemForRenderPipeline
RSlysz Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions com.unity.render-pipelines.core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
Version Updated
The version number for this package has increased due to a version update of a related graphics package.

### Added
- Added MenuItemForRenderPipeline attribute that only show the MenuItem if the current pipeline is one of the ones provided.

## [12.0.0] - 2021-01-11

### Added
Expand Down
6 changes: 0 additions & 6 deletions com.unity.render-pipelines.core/Editor/LookDev/LookDev.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,6 @@ static Context defaultContext
internal static IViewDisplayer currentViewDisplayer => s_ViewDisplayer;
internal static IEnvironmentDisplayer currentEnvironmentDisplayer => s_EnvironmentDisplayer;

[MenuItem("Window/Rendering/Look Dev", false, 10001)]
static void OpenLookDev() => Open();

[MenuItem("Window/Rendering/Look Dev", true, 10001)]
static bool LookDevAvailable() => supported;

internal static bool waitingConfigure { get; private set; } = true;

/// <summary>State of the LookDev window</summary>
Expand Down
Loading