Skip to content

Conversation

FrancescoC-unity
Copy link
Contributor

I was in vacation when changes were made so I didn't review them post @Vic-Cooper changes.

A point was changed to something that might sound misleading, I replaced it with my original phrase, but please let me know if you prefer different wording :-)

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Sep 3, 2021
Copy link
Contributor

@sebastienlagarde sebastienlagarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change is small enough. If there is any mistake Vic please correct in another PR. thanks

@sebastienlagarde sebastienlagarde merged commit 7c9bf16 into master Sep 3, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/correct-line-shouldnt-be-there-in-taa-docs branch September 3, 2021 17:20
sebastienlagarde pushed a commit that referenced this pull request Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants