Skip to content

Conversation

kennytann
Copy link
Contributor

@kennytann kennytann commented Sep 6, 2021


Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

FB: https://fogbugz.unity3d.com/f/cases/1322805/
Case was already closed since it was fixed in the lighting pass but overlooked in the unlit pass


Testing status

Describe what manual/automated tests were performed for this PR

Test using example project in parent case. Make sure scene has no lights to test transparency sort mode/axis during unlit pass.


Comments to reviewers

Notes for the reviewers you have assigned.

@kennytann kennytann requested a review from unity-cchu September 6, 2021 03:35
@kennytann kennytann requested a review from a team as a code owner September 6, 2021 03:35
@kennytann kennytann changed the base branch from master to 2021.1/staging September 6, 2021 03:36
@kennytann kennytann requested a review from a team as a code owner September 6, 2021 03:36
@github-actions
Copy link

github-actions bot commented Sep 6, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@kennytann kennytann changed the title Backport[1322805] Fix sorting mode/axis during unlit pass [1322805] Backport Fix sorting mode/axis during unlit pass Sep 6, 2021
@kennytann kennytann removed the request for review from a team September 7, 2021 02:12
@kennytann kennytann self-assigned this Sep 7, 2021
@BoonKiangTan
Copy link

Fix verified on branch:

Version: 2021.1.18f1.2928
Revision: 2021.1/staging 98a317ec4707
Built: Sun, 08 Aug 2021 21:43:02 GMT
Package branch: 2021.1/2d/backport-1322805 (8112943)

Verified custom transparent sort axis in 2D Renderer is respected for unlit pass
Unity_g7732RcVe1
Unity_dpyapJV4Dj

@kennytann kennytann merged commit c1d9dc4 into 2021.1/staging Sep 8, 2021
@kennytann kennytann deleted the 2021.1/2d/backport-1322805 branch September 8, 2021 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants