Skip to content

Conversation

alex-vazquez
Copy link
Contributor


Purpose of this PR

From generic code on Core is imposible to know where an Additional Data component is from URP or HDRP.

There are some PR's comming and improving some x-pipeline workflows, so this PR is a shared between them.


Testing status

Test the compilation.


Comments to reviewers

Some other PR will use this interface.

@alex-vazquez alex-vazquez requested a review from RSlysz September 7, 2021 14:42
@alex-vazquez alex-vazquez self-assigned this Sep 7, 2021
@github-actions
Copy link

github-actions bot commented Sep 7, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk

URP
/.yamato%252Fall-urp.yml%2523PR_URP_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@RSlysz RSlysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will help us find all additional data.

When refactor of them will land, User can still want to have additional data for component we don't think of. So adding it will still be needed. But perhaps we should need to move it to trunk with the refactor to add it on all extensions.

@alex-vazquez alex-vazquez marked this pull request as ready for review September 8, 2021 08:58
@alex-vazquez alex-vazquez requested review from a team as code owners September 8, 2021 08:58
@alex-vazquez alex-vazquez changed the title SRP Workflows - New Additional Data Interface to be able to identify additional data's on Core Package SRP Workflows - New Additional Data Interface to be able to identify additional data's in Core Package Sep 8, 2021
Copy link
Contributor

@martint-unity martint-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alex-vazquez alex-vazquez merged commit 88346ec into master Sep 8, 2021
@alex-vazquez alex-vazquez deleted the x-pipeline/additional-data-interface branch September 8, 2021 09:06
sebastienlagarde pushed a commit that referenced this pull request Sep 12, 2021
@RSlysz
Copy link
Contributor

RSlysz commented Oct 14, 2021

Github bot test @arttu-peltonen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants