-
Notifications
You must be signed in to change notification settings - Fork 855
SRP Workflows - Move VolumeDebugSettings to Core #5580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Pretty minor comments (mostly typos/docs).
com.unity.render-pipelines.core/Runtime/Debugging/IVolumeDebugSettings.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.core/Runtime/Debugging/IVolumeDebugSettings.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/Debug/HDVolumeDebugSettings.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.core/Runtime/Debugging/VolumeDebugSettings.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Runtime/Debug/DebugDisplay.cs
Show resolved
Hide resolved
com.unity.render-pipelines.core/Runtime/Debugging/VolumeDebugSettings.cs
Outdated
Show resolved
Hide resolved
@Unity-Technologies/gfx-qa-hdrp please test the Volume debug panel on editor and on standalone build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked HDRP volume debug view both in editor and built player. No issues ✔
Purpose of this PR
https://jira.unity3d.com/browse/XPIPELINE-264
First step towards moving the Volume Debug Panel to URP.
Making an interface with the data and implement it on HDRP.
IVolumeDebugSettings <- VolumeDebugSettings <- HDVolumeDebugSettings / (UniversalRenderPipelineVolumeDebugSettings)
Testing status
Testing that the debug panel works in the same way.