Skip to content

Conversation

julienamsellem
Copy link
Contributor

Backport to 2021.2

Purpose of this PR

Revert this PR which was already a revert (so put back the initial PR in place)
#5122


Testing status

Tested with a Color Operator


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

github-actions bot commented Sep 9, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@julienamsellem julienamsellem marked this pull request as ready for review September 10, 2021 12:05
@PaulDemeulenaere
Copy link
Contributor

The failure from editMode comes from issue with VFXSamplerCubeArray

Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double check with change of #5590
Looks identical 🟢

@PaulDemeulenaere
Copy link
Contributor

Side note: the branch should be named 2021.2/vfx/fix/1291991-colorpicker-keeps-updating-2

@julienamsellem julienamsellem merged commit 87fd5c9 into 2021.2/staging Sep 15, 2021
@julienamsellem julienamsellem deleted the vfx/fix/2021.2/1291991-colorpicker-keeps-updating-2 branch September 15, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants