Backport of 2d/fix for self shadow #5617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytann
approved these changes
Sep 13, 2021
|
|
||
| private static void OnPlayModeStateChanged(PlayModeStateChange state) | ||
| { | ||
| if (state == PlayModeStateChange.ExitingEditMode || state == PlayModeStateChange.ExitingPlayMode) |
There was a problem hiding this comment.
You should add a null check for s_ShadowCasterGroups here as it was causing a NullReferenceException
phi-lira
suggested changes
Sep 29, 2021
com.unity.render-pipelines.universal/Runtime/Materials/ParticlesUnlit.mat
Outdated
Show resolved
Hide resolved
phi-lira
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for PR maker
CHANGELOG.mdfile.Purpose of this PR
This is a backport of 0d1d0f8