[10.x] Define ENABLE_HYBRID_RENDERER_V2 by default for Hybrid Renderer 0.14.0 and newer [V2] #5635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-breysse
requested review from
PaulDemeulenaere,
cdxntchou and
joeldevahl
joeldevahl
reviewed
Sep 13, 2021
com.unity.render-pipelines.core/Runtime/Unity.RenderPipelines.Core.Runtime.asmdef
Show resolved
Hide resolved
joeldevahl
approved these changes
Sep 13, 2021
vincent-breysse
changed the title
|
Needs to be forward ported once we can test DOTS with SRP 11/12. Currently, the latest editor version compatible with DOTS is |
PaulDemeulenaere
approved these changes
Sep 15, 2021
| "name": "com.unity.rendering.hybrid", | ||
| "expression": "0.14.0-preview.0", | ||
| "define": "ENABLE_HYBRID_RENDERER_V2" | ||
| } |
There was a problem hiding this comment.
It impacts the usage of
- DecalSubTarget
- HDTarget
It looks good to me, also discussed about this with @alelievr
cdxntchou
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable HRV2 by default for DOTS 0.5 since HRV1 will be removed.
This PR is completing (or rather reworking) the V1 that can be found here #5507
Unfortunately, we noticed a bit too late that more asmdef files had to be updated
Testing status
This change is supposed to be tested with HRV1 removed on a project not defining
ENABLE_HYBRID_RENDERER_V2explicitly in the ProjectSettings.Since HRV1 removal has not landed on DOTS master yet, I tested by locally adding the same asmdef change to the file
com.unity.rendering.hybrid/Unity.Rendering.Hybrid/Unity.Rendering.Hybrid.asmdef. This is to ensure I wasn't testing with the define enabled globally for the project, which would be pointless.Changelog
com.unity.rendering.hybrid
ENABLE_HYBRID_RENDERER_V2by default for Hybrid Renderer 0.14.0 and newer