Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNI-11984 - Lens Flare docs #5640

Merged
merged 9 commits into from
Sep 16, 2021
Merged

UNI-11984 - Lens Flare docs #5640

merged 9 commits into from
Sep 16, 2021

Conversation

JordanL8
Copy link
Contributor

@JordanL8 JordanL8 commented Sep 13, 2021 •
edited
Loading

Purpose of this PR

Work for https://unity3d.atlassian.net/browse/UNI-11984. Consisted of changing file names and links to adhere to naming conventions, adding some workflow information for creating a lens flare, and adding missing links to the toc.

@JordanL8 JordanL8 requested review from a team as code owners September 13, 2021 16:02
@github-actions github-actions bot added the HDRP label Sep 13, 2021
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk
With changes to HDRP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

URP
/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

erikabar
erikabar approved these changes Sep 15, 2021
View reviewed changes
Copy link

@erikabar erikabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed doc changes, looks good.

Vic-Cooper
Vic-Cooper requested changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a teeny tiny typo!

...ty.render-pipelines.high-definition/Documentation~/shared/lens-flare/lens-flare-component.md Outdated

To create a lens flare in a scene:

1. Create or select a GameObject to attach the lens flare too.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Too" :D Should be "to".

@sebastienlagarde
Copy link
Contributor

adressed pr feedback, merging

@sebastienlagarde sebastienlagarde merged commit cd6a08d into master Sep 16, 2021
@sebastienlagarde sebastienlagarde deleted the universal/uni-11984-lens-flare branch September 16, 2021 18:15
sebastienlagarde added a commit that referenced this pull request Sep 20, 2021
@JordanL8 @sebastienlagarde
UNI-11984 - Lens Flare docs (#5640)
c817ed5 
* Updated lens flare screenshots for URP

* Updated docs for lens flare asset

* Updated toc with lens flare entries and changed image names

* Updated the lens flare component and lens flare asset pages

* Corrected links

* Updated HDRP version of the lens flare docs

* Shifted format for URP and HDRP to use the shared folders

* Corrected links and removed old docs from HDRP

* Update lens-flare-component.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikabar erikabar erikabar approved these changes

@oleks-k oleks-k Awaiting requested review from oleks-k

@Vic-Cooper Vic-Cooper Awaiting requested review from Vic-Cooper

@sebastienlagarde sebastienlagarde Awaiting requested review from sebastienlagarde

Assignees
No one assigned
Labels
backported-2021.2 Docs HDRP universal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JordanL8 @sebastienlagarde @erikabar @Vic-Cooper