Skip to content

[HDRP] APV fix profile asset not deleted when deleting a baking set #5641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2021
Merged

[HDRP] APV fix profile asset not deleted when deleting a baking set #5641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeBakingWindow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,11 @@ void InitializeBakingSetList()
EditorUtility.DisplayDialog("Can't delete baking set", "You can't delete the last Baking set. You need to have at least one.", "Ok");
return;
}
if (EditorUtility.DisplayDialog("Delete the selected baking set?", $"Do you really want to delete the baking set '{sceneData.bakingSets[list.index].name}'?", "Yes", "Cancel"))
if (EditorUtility.DisplayDialog("Delete the selected baking set?", $"Deleting the baking set will also delete it's profile asset on disk.\nDo you really want to delete the baking set '{sceneData.bakingSets[list.index].name}'?\n\nYou cannot undo the delete assets action.", "Yes", "Cancel"))
{
var pathToDelete = AssetDatabase.GetAssetPath(sceneData.bakingSets[list.index].profile);
if (!String.IsNullOrEmpty(pathToDelete))
AssetDatabase.DeleteAsset(pathToDelete);
Undo.RegisterCompleteObjectUndo(sceneData.parentAsset, "Deleted baking set");
ReorderableList.defaultBehaviours.DoRemoveButton(list);
}
Expand Down