Skip to content

Fix HDRP unlit sub target #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2020
Merged

Fix HDRP unlit sub target #566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,12 @@ static void AddToggleProperty(this PropertyCollector collector, string reference

public static void AddStencilShaderProperties(PropertyCollector collector, SystemData systemData, LightingData lightingData)
{
bool ssrEnabled = systemData.surfaceType == SurfaceType.Opaque ? lightingData.receiveSSR : lightingData.receiveSSRTransparent;
bool ssrEnabled = false;

if (lightingData != null)
ssrEnabled = systemData.surfaceType == SurfaceType.Opaque ? lightingData.receiveSSR : lightingData.receiveSSRTransparent;

BaseLitGUI.ComputeStencilProperties(ssrEnabled, lightingData.subsurfaceScattering, out int stencilRef, out int stencilWriteMask,
BaseLitGUI.ComputeStencilProperties(ssrEnabled, lightingData != null && lightingData.subsurfaceScattering, out int stencilRef, out int stencilWriteMask,
out int stencilRefDepth, out int stencilWriteMaskDepth, out int stencilRefGBuffer, out int stencilWriteMaskGBuffer,
out int stencilRefMV, out int stencilWriteMaskMV
);
Expand All @@ -93,9 +96,9 @@ public static void AddStencilShaderProperties(PropertyCollector collector, Syste
collector.AddIntProperty("_StencilRefGBuffer", stencilRefGBuffer);
collector.AddIntProperty("_ZTestGBuffer", 4);

collector.AddToggleProperty(kUseSplitLighting, lightingData.subsurfaceScattering);
collector.AddToggleProperty(kReceivesSSR, lightingData.receiveSSR);
collector.AddToggleProperty(kReceivesSSRTransparent, lightingData.receiveSSRTransparent);
collector.AddToggleProperty(kUseSplitLighting, lightingData != null && lightingData.subsurfaceScattering);
collector.AddToggleProperty(kReceivesSSR, lightingData != null && lightingData.receiveSSR);
collector.AddToggleProperty(kReceivesSSRTransparent, lightingData != null && lightingData.receiveSSRTransparent);
}

public static void AddBlendingStatesShaderProperties(
Expand Down