Skip to content

Trying to fix an error stemming from calling SetAdditionalBakedProbes from the wrong thread. #5690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 16, 2021
Merged

Trying to fix an error stemming from calling SetAdditionalBakedProbes from the wrong thread. #5690

merged 4 commits into from
Sep 16, 2021

Conversation

FrancescoC-unity
Copy link
Contributor

There was an error reported with SetAdditionalBakedProbes coming from the destructor of AdditionalGIBakeRequestsManager in another thread but the main thread.

I moved the logic to an explicit Dispose function called during disposal of the render pipeline. By checking with a bunch of debug logs, that dispose seems to be called on main thread so this should be fine.

I never reproed so this is a bit speculative, but worse case this pretty much a no-op.

@FrancescoC-unity FrancescoC-unity self-assigned this Sep 16, 2021
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the SRP label Sep 16, 2021
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@sebastienlagarde sebastienlagarde merged commit bf73a9d into master Sep 16, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/tentative-fix-for-calling-set-additional-probes branch September 16, 2021 18:29
sebastienlagarde pushed a commit that referenced this pull request Sep 20, 2021
@FrancescoC-unity @sebastienlagarde
Trying to fix an error stemming from calling SetAdditionalBakedProbes…
d439e49 
… from the wrong thread. (#5690)

* Move cleanup to cleanup and not destructor.

* Init too

* Use right guards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alelievr alelievr Awaiting requested review from alelievr

2 more reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@JulienIgnace-Unity JulienIgnace-Unity JulienIgnace-Unity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@FrancescoC-unity FrancescoC-unity

Labels

backported-2021.2 HDRP SRP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FrancescoC-unity @sebastienlagarde @JulienIgnace-Unity