Srp workflows - Debug panel system to core #5726
Conversation
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. URP SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
alex-vazquez
requested review from
a team and
RSlysz
and removed request for
a team,
RSlysz and
fredericv-unity3d
alex-vazquez
changed the title
| namespace UnityEngine.Rendering | ||
| { | ||
| /// <summary> | ||
| /// Templated class for <see cref="IDebugDisplaySettings"/> |
There was a problem hiding this comment.
The comment should describe how to use the class. Like: "Subclass this to benefit for commonly used features regarding IDebugDisplaySettings"
| { | ||
| protected readonly HashSet<IDebugDisplaySettingsData> m_Settings = new HashSet<IDebugDisplaySettingsData>(); | ||
|
|
||
| private static readonly Lazy<T> s_Instance = new Lazy<T>(() => |
There was a problem hiding this comment.
Do we need to clear the data when entering or exiting playmode?
Note: When domain reload is not performed, the C# statics are not cleared and can contain invalid values.
| namespace UnityEngine.Rendering.Universal | ||
| namespace UnityEngine.Rendering | ||
| { | ||
| public abstract class DebugDisplaySettingsPanel : IDebugDisplaySettingsPanelDisposable |
There was a problem hiding this comment.
The class is disposable, although it can still be used while disposed. Is it intended?
|
@Unity-Technologies/gfx-qa-urp Please do a smoke test to the Rendering Debugger in
|
7 participants
Purpose of this PR
https://jira.unity3d.com/browse/XPIPELINE-264
Moving all Debug Panel framework to Core in order to be able to implement the Volumes Panel on URP.
Testing status
Testing the URP debug panels work in the same way
Comments to reviewers
Simply doing a templated class with common functinality for URP and HDRP and move all the interfaces to Core.