Srp workflows - Improvements working with Volume Components on a XPipeline Projects [Hold] #5745
Conversation
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
|
|
||
| internal void InitShowOnlyOverridedParametersPreference() | ||
| { | ||
| string key = $"UI_Show_Only_Overrided_Parameters_{GetType()}"; |
There was a problem hiding this comment.
It's sad that we cannot statically cache this or make it const. With inheritance, I can't see anyway to achieve it ;_;
| } | ||
| } | ||
|
|
||
| void SetIsSupportedOnCurrentPipeline(VolumeComponent component, Type currentPipelineType) |
There was a problem hiding this comment.
[Readability] Either rename currentPipelineType to renderPipelineType or make the method find who is the current one.
There was a problem hiding this comment.
Same goes for method name. It should be SetIsSupportedOnPipeline if the method don't get who is the current one
| else | ||
| menu.AddDisabledItem(EditorGUIUtility.TrTextContent("Show Additional Properties")); | ||
| menu.AddItem(EditorGUIUtility.TrTextContent("Show All Additional Properties..."), false, () => CoreRenderPipelinePreferences.Open()); | ||
| menu.AddItem(EditorGUIUtility.TrTextContent("Show Only Overrided Parameters"), targetEditor.showOnlyOverridedParameters, () => targetEditor.showOnlyOverridedParameters = !targetEditor.showOnlyOverridedParameters); |
There was a problem hiding this comment.
Proper form is "overridden", not "overrided". Replace at least user-facing text, preferably also variable names.
alex-vazquez
force-pushed
the
srp-workflows/volumes-multiple-pipelines
branch
from
dea4b87 to
4d57758
Compare
|
Guess just run Yamato and merge? |
|
@sebastienlagarde we are going to put on hold this PR, until @fredericv-unity3d merge his PR as this will change drastically with his improvements. |
sebastienlagarde
changed the title
6 participants
Purpose of this PR
https://jira.unity3d.com/browse/XPIPELINE-327
https://jira.unity3d.com/browse/XPIPELINE-328
Warning for Volume Components from another pipeline:
Add an option to hide not overrided parameters for a component
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.