Skip to content

Conversation

peterjohnlong
Copy link
Contributor


Purpose of this PR

This PR is to attempt to fix fogbugz case https://fogbugz.unity3d.com/f/cases/1366011/
Where Realtime Raytracing (Preview) checkbox is ticked and then build target is switched to non raytrace console platform,
there are a continuous stream of errors output in the editor console window about missing compute kernels etc.

Testing status

Locally tested that it fix the issue in the bug report. Local test tested that HDRP_DXR test still work as expected on a console target where raytrace is supported (tested console build was built under both DX11 and DX12 editor API).


Comments to reviewers

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk
With changes to HDRP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@anisunity
Copy link
Contributor

I still need to test on a ps4 to make sure it's okay

@anisunity anisunity marked this pull request as ready for review September 30, 2021 06:05
@anisunity anisunity requested review from a team and sebastienlagarde September 30, 2021 06:05
@sebastienlagarde sebastienlagarde merged commit 40ad400 into master Sep 30, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/case1366011 branch September 30, 2021 07:59
@sebastienlagarde
Copy link
Contributor

For QA: Anis have done the QA pass on this PR, so no need for further testing

sebastienlagarde pushed a commit that referenced this pull request Sep 30, 2021
…#5760)

* Fix for case 1366011 debug spew when switch target to non RT platform

* Fix UI RT

Co-authored-by: Anis Benyoub <anis@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Oct 11, 2021
…rget to non RT platform (#5978)

* Fix for case 1366011 debug spew when switch target to non RT platform #5760

* Fix compil issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants