Skip to content

Fix memory leak with XR combined occlusion meshes #5772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2021
Merged

Fix memory leak with XR combined occlusion meshes #5772

merged 1 commit into from
Sep 23, 2021

Conversation

fabien-unity
Copy link
Collaborator

Purpose of this PR

Testing status

  • tested with repro project

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk
With changes to HDRP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

URP
/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@sebastienlagarde sebastienlagarde marked this pull request as ready for review September 23, 2021 09:16
@sebastienlagarde sebastienlagarde requested review from a team as code owners September 23, 2021 09:16
@sebastienlagarde sebastienlagarde merged commit b558c60 into master Sep 23, 2021
@sebastienlagarde sebastienlagarde deleted the xr/fix-leak-combined-occlusion-mesh branch September 23, 2021 09:17
sebastienlagarde pushed a commit that referenced this pull request Sep 23, 2021
@fabien-unity @sebastienlagarde
Fix memory leak with XR combined occlusion meshes #5772
93db70f
fabien-unity added a commit that referenced this pull request Sep 23, 2021
@fabien-unity
bcakport #5772
f269f25
sebastienlagarde pushed a commit that referenced this pull request Oct 15, 2021
@fabien-unity @sebastienlagarde
Fix memory leak with XR combined occlusion meshes #5772
561294f
sebastienlagarde pushed a commit that referenced this pull request Jan 31, 2022
@fabien-unity
Unify XR code into SRP Core [22.1] (#3557)
970b4a1 
* Refactor XR code for URP and HDRP

* Edit CODEOWNERS file with xr-graphics

* rename some methods

* rename some methods, code cleanup

* fix formatting

* some changes after PR feedback

* Move new XR API to experimental namespace until stabilized

* run formatting tool

* Apply reformat changes

* remove Android check for late-checking

* edit comment

* Add mechanism to allow render pipelines to extend XRPass implementation

* bcakport #5772

* Add XRSystemUniversal

* Port PR#5790

* fix late-latching unmark commands not being executed

* Add missing documentation to new API

* Add missing documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@phi-lira phi-lira phi-lira approved these changes

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-10.x backported-2021.2 HDRP universal XR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabien-unity @phi-lira @sebastienlagarde