Skip to content

Conversation

julienamsellem
Copy link
Contributor

@julienamsellem julienamsellem commented Sep 23, 2021

Purpose of this PR

Few icons were added but not tracked with LFS in this PR #5706

Here is how the newly added files appear in Fork
Fork_M6kVfYXNxH


Testing status

Icons are displayed correctly in the VFX graph editor toolbar


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@theopnv theopnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
image

though it's hard to be 100% sure of these kind of things, git-lfs is quite confusing once something goes off tracks. Let's double check everything is good for everyone after the merge.
Thanks Julien!

Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (we can't really check this in diff)
If at least someone tried to checkout your branch, it should be fine (the formatting job would fail if there is a missing large file)

@julienamsellem julienamsellem marked this pull request as ready for review September 24, 2021 13:56
@julienamsellem julienamsellem merged commit 94686db into master Sep 24, 2021
@julienamsellem julienamsellem deleted the vfx/fix/missing-lfs-icons branch September 24, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants