Skip to content

Conversation

kennytann
Copy link
Contributor


Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Backport for #4489
https://fogbugz.unity3d.com/f/cases/1315645/


Testing status

Describe what manual/automated tests were performed for this PR

Test user project outlined in FB case


Comments to reviewers

Notes for the reviewers you have assigned.

@kennytann kennytann self-assigned this Sep 27, 2021
@kennytann kennytann requested review from a team as code owners September 27, 2021 04:26
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@kennytann kennytann changed the title [Backport 1315645] Fixed 2D lighting in perspective camera mode [Backport 1315645][2021.1] Fixed 2D lighting in perspective camera mode Sep 27, 2021
@BoonKiangTan
Copy link

Fix verified on branch:

Version: 2021.1.22f1.3070
Revision: 2021.1/staging 5bcd44919440
Built: Wed, 08 Sep 2021 21:39:46 GMT
Package branch: 2021.1/2d/backport-1315645 (c777c68)

Verified light falloff is gradual in all directions and no ray of light artifacts

Copy link

@ernestasKupciunas ernestasKupciunas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving without testing. Developer already tested the original FB case. Good job!

@kennytann kennytann merged commit 027e6b9 into 2021.1/staging Oct 5, 2021
@kennytann kennytann deleted the 2021.1/2d/backport-1315645 branch October 5, 2021 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants