Skip to content

Conversation

pierre-unity
Copy link
Contributor

(PR made by Anis)
This PR updates the presets for the volumetric clouds and fixes typos in the documentation and tooltips. It also changes the default values for the clouds volume component.

Screenshot4
Screenshot6
Screenshot9
Screenshot1

Testing status
Extensively tested by @pierre-unity
This will break all the tests that have clouds in them, we will need to update all the relative screenshots.

…mentation.

tuned presets, updated tooltips

updated default powder effect, added missing type

randomized some values to reduce erosion tiling

tuned presets

less erosion at base of cumulonimbus, tuned preset

fixed grammar

- Updated volumetric cloud presets and fixed typos in respective documentation.
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk
With changes to HDRP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@pierre-unity pierre-unity marked this pull request as ready for review September 28, 2021 12:21
@anisunity
Copy link
Contributor

I'll be updating the screenshots

@anisunity
Copy link
Contributor

Screenshots updated, relaunching tests.

@anisunity anisunity merged commit 13dbadd into master Sep 28, 2021
@anisunity anisunity deleted the hdrp-clouds-temporary-experimentations branch September 28, 2021 19:03
sebastienlagarde added a commit that referenced this pull request Sep 30, 2021
…ntation. (#5804)

* - Updated volumetric cloud presets and fixed typos in respective documentation.

tuned presets, updated tooltips

updated default powder effect, added missing type

randomized some values to reduce erosion tiling

tuned presets

less erosion at base of cumulonimbus, tuned preset

fixed grammar

- Updated volumetric cloud presets and fixed typos in respective documentation.

* Update CHANGELOG.md

* Update all failing screenshots

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
Co-authored-by: Anis Benyoub <anis@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants