Skip to content

Conversation

fcoulombe
Copy link
Contributor

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

This makes it consistent with what happens in URP and HDRP


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

…isabled by default

This makes it consistent with what happens in URP and HDRP
@sebastienlagarde
Copy link
Contributor

hi, please add a changelog and also comment what you tested. Thank you

@fcoulombe fcoulombe closed this Sep 28, 2021
@fcoulombe
Copy link
Contributor Author

we apparently don't want to modify the behavior to align with future pipeline.

@fcoulombe fcoulombe deleted the xr/graphics/PPvolume-layer-fix branch September 28, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants