Skip to content

Conversation

fcoulombe
Copy link
Contributor

@fcoulombe fcoulombe commented Sep 28, 2021

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

The Post Processs unit tests are currently broken.
Some of those tests seems to run in HDR but didn't have HDR enabled in the test settings.
This change enables HDR wherever it needs it.

Testing status

2020.3.11f1, 2019.4.30f1

I ran the tests in test runner and then had yamato run the postprocess test suites.
https://unity-ci.cds.internal.unity3d.com/job/9036790
https://unity-ci.cds.internal.unity3d.com/job/9036790
https://unity-ci.cds.internal.unity3d.com/job/9036774

I believe the breakage for OSX is not new.


Comments to reviewers

Notes for the reviewers you have assigned.

@fcoulombe fcoulombe marked this pull request as ready for review September 28, 2021 18:01
Copy link
Contributor

@mikesfbay mikesfbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fcoulombe Have you tried 2019 LTS or 2020 LTS on these tests? For Postprocessing package v2 for built-in, I believe we deprecated it since 2018 LTS. Thus, the scenes were created with older Unity versions (i.e. 2018 LTS, 2019). If automated test failed for trunk, we shouldn't assume trunk is the target if the ultimate backport targets are for 2019 LTS or 2020 LTS (for majority of users still on v2). I.e. One should run Custom yamato with unity version set to 2019 LTS or 2020 LTS.

@fcoulombe
Copy link
Contributor Author

@fcoulombe Have you tried 2019 LTS or 2020 LTS on these tests? For Postprocessing package v2 for built-in, I believe we deprecated it since 2018 LTS. Thus, the scenes were created with older Unity versions (i.e. 2018 LTS, 2019). If automated test failed for trunk, we shouldn't assume trunk is the target if the ultimate backport targets are for 2019 LTS or 2020 LTS (for majority of users still on v2). I.e. One should run Custom yamato with unity version set to 2019 LTS or 2020 LTS.

Let me know if you think I should test other versions but comparing test results with master, it seems to improve the number of successful test.

<style type="text/css"></style>

custom version branch yamoto link     test success  
2020.3.11f1 master https://unity-ci.cds.internal.unity3d.com/job/9050827     6/14  
2019.4.30f1 master https://unity-ci.cds.internal.unity3d.com/job/9050812     6/14  
2018.4.36f1 master https://unity-ci.cds.internal.unity3d.com/job/9050785     2/14  
             
2020.3.11f1 with hdr enabled https://unity-ci.cds.internal.unity3d.com/job/9050883     12/14  
2019.4.30f1 with hdr enabled https://unity-ci.cds.internal.unity3d.com/job/9050879     9/14  
2018.4.36f1 with hdr enabled https://unity-ci.cds.internal.unity3d.com/job/9050865     2/14  

@sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde merged commit ecbf94c into master Oct 8, 2021
@sebastienlagarde sebastienlagarde deleted the xr/graphics/fix-ppv2-tests branch October 8, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants