Skip to content

[ShaderGraph][2019.4][Backport] Ensure varying ordering by making instance ID SystemGenerated #5846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[ShaderGraph][2019.4][Backport] Ensure varying ordering by making instance ID SystemGenerated #5846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
536ba03
Fix for 1369011 - Instance ID needs to be SystemGenerated to be order…
jessebarker Sep 29, 2021
645a7d3
Update changelog with fix for 1369011
jessebarker Sep 29, 2021
b7fda78
Merge remote-tracking branch 'refs/remotes/origin/7.x.x/release' into…
jessebarker Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion com.unity.render-pipelines.universal/Editor/ShaderGraph/UniversalShaderGraphResources.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ internal struct Varyings
Vector4 fogFactorAndVertexLight;
[Optional]
Vector4 shadowCoord;
[Semantic("CUSTOM_INSTANCE_ID")] [PreprocessorIf("UNITY_ANY_INSTANCING_ENABLED")]
[Semantic("CUSTOM_INSTANCE_ID")]
[SystemGenerated]
[PreprocessorIf("UNITY_ANY_INSTANCING_ENABLED")]
uint instanceID;
[Semantic("SV_RenderTargetArrayIndex")]
[SystemGenerated]
Expand Down
4 changes: 2 additions & 2 deletions com.unity.shadergraph/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [7.8.0] - 2021-07-23

Version Updated
The version number for this package has increased due to a version update of a related graphics package.
### Fixed
- Fixed the ordering of varyings in a struct that could cause an error when compiling for XR on Android. [1369011](https://issuetracker.unity3d.com/product/unity/issues/guid/1361049/)

## [7.7.0] - 2021-04-28

Expand Down