Skip to content

Conversation

eh-unity
Copy link
Contributor

Purpose of this PR

Fix usage of stale data for main light cookie when only additional lights cookie(s) are active.
Backport of: 5828


Testing status

Quick manual testing.


Comments to reviewers

Notes for the reviewers you have assigned.

@eh-unity eh-unity requested a review from ellioman September 29, 2021 15:24
@eh-unity eh-unity marked this pull request as ready for review September 29, 2021 15:24
@eh-unity eh-unity requested review from a team as code owners September 29, 2021 15:24
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@eh-unity
Copy link
Contributor Author

Test failures are not related to light-cookies. This PR only touches light cookie code.

@eh-unity eh-unity merged commit e185590 into 2021.2/staging Sep 30, 2021
@eh-unity eh-unity deleted the 2021.2/universal/backport/light-cookies-fix-dir-light-toggle branch September 30, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants