Skip to content

Urp perf/xrquest fix tests #5869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2021
Merged

Urp perf/xrquest fix tests #5869

merged 3 commits into from
Oct 1, 2021

Conversation

ejazm
Copy link
Contributor

@ejazm ejazm commented Oct 1, 2021 •
edited
Loading

Purpose of this PR

The XRQuest tests have been failing due to recent changes in the pipeline

  • The Android build image have been updated here
  • Android SDK path was updated here.
  • Since XRQuest is Android platform it needed to be updated and be in alignment with the rest of the Android jobs

Testing status

XRQuest jobs on URP Perf pipeline should be green

@github-actions github-actions bot added the sdet label Oct 1, 2021
@ejazm ejazm self-assigned this Oct 1, 2021
@ejazm ejazm requested review from kivistikliis, sophiaaar and theopnv and removed request for sophiaaar and theopnv October 1, 2021 12:05
@ejazm ejazm marked this pull request as ready for review October 1, 2021 13:39
@ejazm ejazm requested a review from a team as a code owner October 1, 2021 13:39
sophiaaar
sophiaaar approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@sophiaaar sophiaaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked that the yml generates correctly and confirmed that the error is not caused by this pr, LGTM

@ejazm ejazm merged commit ff6e565 into master Oct 1, 2021
@ejazm ejazm deleted the urp-perf/xrquest-fix-tests branch October 1, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kivistikliis kivistikliis Awaiting requested review from kivistikliis

1 more reviewer

@sophiaaar sophiaaar sophiaaar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ejazm ejazm

Labels

sdet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ejazm @sophiaaar