[VFX] Fix usage on texture internally in SG (to 2021.2) #5914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix case https://fogbugz.unity3d.com/f/cases/1367167/ Regression introduced by #5416 We should also include texture internally declared in SG -_-' * *Improve coverage using a texture only internally in shaderGraph It shouldn't modify the image reference * *Update changelog.md (cherry picked from commit 9c71fab) # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
julienf-unity
approved these changes
Oct 21, 2021
PaulDemeulenaere
deleted the
2021.2/vfx/fix/1367167-regression-of-texture-redefinition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Backport of #5793
Testing status
Yamato 🟢
Comments to reviewers
N/A