Skip to content

Conversation

alindmanUnity
Copy link
Contributor

port from SRP

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?
Backport of #59
Previously, the Create Node menu/searcher window regenerated an instance of every node on every load call. This makes minor improvements to the caching of entries to speed up the load of the searcher for the majority of calls.
The searcher window will now only generate new entries when changes to properties or keywords are detected, or when the shader graph window is refocused (to account for subgraph changes). Only the first invoke after these changes are detected will lag, and every call after that will use a cache and load much faster.
More improvements can be made later as well but this speeds up 80% of the use of the searcher and is probably worth putting in for UX improvements.
Issue link: public internal


Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Other:
  • Rapidly opened and closed the searcher (using spacebar) and observed rapidly improved load times.
  • Added many properties, keywords, and nodes from the searcher entries to the graph to ensure there are no guid errors in the copy system.
  • Checked that when refocusing the window, adding, removing, or changing a property or keyword the next load did lag, but reflected the changes in the search entries. Every load after that remained fast.

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/78-ScriptableRenderPipeline

Any test projects to go with this to help reviewers?


Comments to reviewers

Notes for the reviewers you have assigned.

@alindmanUnity alindmanUnity self-assigned this Apr 8, 2020
@alindmanUnity alindmanUnity requested review from a team April 8, 2020 19:12
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on SRP

@marctem marctem merged commit b76e0f2 into 8.x.x/release Apr 9, 2020
@marctem marctem deleted the 8.x.x/sg/speedy-searcher branch April 9, 2020 22:19
AndrewSaraevUnity added a commit that referenced this pull request Feb 3, 2022
* Fixed compilation error when Probe Volumes are not encoded with SHL2. Dynamic GI still doesn't work with it but baked lighting does.

* Fixed Dynamic GI and the neighborhood debug draw when there are 0 hits in a volume (no geometry was hit).
mohammad22 pushed a commit that referenced this pull request Mar 2, 2022
* Fixed compilation error when Probe Volumes are not encoded with SHL2. Dynamic GI still doesn't work with it but baked lighting does.

* Fixed Dynamic GI and the neighborhood debug draw when there are 0 hits in a volume (no geometry was hit).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants