Updated code owner for URP #6052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
ellioman
approved these changes
Oct 18, 2021
sophiaaar
reviewed
Oct 18, 2021
.github/CODEOWNERS
Outdated
| # Universal RP General | ||
| # Universal RP Team and URP Guardian | ||
| /com.unity.render-pipelines.universal/ @Unity-Technologies/universal-rp-team @Unity-Technologies/urp-trunk-guardian | ||
| /com.unity.testing.urp-upgrade/ @Unity-Technologies/universal-rp-team @Unity-Technologies/url-trunk-guardian |
There was a problem hiding this comment.
Nice catch. Fixed.
sophiaaar
approved these changes
Oct 18, 2021
odbb
added a commit
that referenced
this pull request
Oct 19, 2021
* master: Enable iris normal for Eye shader (#5880) Update to HDRP Asset analytics (#6060) [HDPR] Update reference screenshots for Linux Vulkan Update 206_Motion_Vectors.png (#6046) Updated code owner for URP (#6052) [URP] Re-enable ios pbr tests #5983 Fix error when using gizmos with camera stack in editor #5913 emitting UI geometry for offscreen cameras too (case 1344969 fix) #5894 Remove deprecated UNITY_USE_NATIVE_HDR keyword from shader code. #5569 [XR][URP] Fix issue with vignette location in XR #5471 #5471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR increases coverage of code ownership for URP team.
Testing status
Not needed.
Comments to reviewers
Universal RP teamownership means code reviewURP Trunk Guardianownership means review or URP jobs are green before approving for merge.