Skip to content

Conversation

robin-demoor
Copy link
Contributor

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • [N/A] Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • [N/A] Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?
https://fogbugz.unity3d.com/f/cases/1360233/
Fixes issue where filtered scene view doesn't work.


Testing status

Describe what manual/automated tests were performed for this PR
Fix manually verified in repro project.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@ernestasKupciunas ernestasKupciunas requested a review from a team October 18, 2021 14:51
@phi-lira phi-lira marked this pull request as ready for review October 26, 2021 15:10
@phi-lira phi-lira requested review from a team as code owners October 26, 2021 15:10
@phi-lira phi-lira changed the base branch from master to universal/staging October 26, 2021 15:11
@phi-lira phi-lira merged commit 49b3f73 into universal/staging Oct 26, 2021
@phi-lira phi-lira deleted the universal/fix-sceneview-filter branch October 26, 2021 15:11
phi-lira added a commit that referenced this pull request Nov 9, 2021
* fix case 1360233, correct rt setup for filter view

* add changelog

Co-authored-by: Felipe Lira <felipedrl@gmail.com>
@phi-lira phi-lira mentioned this pull request Nov 9, 2021
This was referenced Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants