Skip to content

Conversation

arttu-peltonen
Copy link
Contributor

@arttu-peltonen arttu-peltonen commented Oct 19, 2021

Purpose of this PR

Fixes 1374181. Currently the "Reflections with Smoothness" lighting debug mode on URP doesn't make sense. This PR fixes that. See screenshots for comparison.

To recap, the "Reflection" debug mode describes what the specular portion of lighting would look like using perfectly smooth mirror-like materials. The "Reflection with smoothness" debug mode does the same thing, but doesn't override smoothness to 1 and instead uses the smoothness value from each material.

Debug mode: None:
image

Debug mode: Reflection (before & after):
image

Debug mode: Reflection with smoothness (before):
image

Debug mode: Reflection with smoothness (after):
image


Testing status

Tested debug mode manually in URP template.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@arttu-peltonen arttu-peltonen changed the base branch from master to universal/staging October 19, 2021 08:25
@arttu-peltonen arttu-peltonen changed the base branch from universal/staging to master October 19, 2021 08:27
@arttu-peltonen arttu-peltonen marked this pull request as ready for review October 19, 2021 08:27
@arttu-peltonen arttu-peltonen requested review from a team as code owners October 19, 2021 08:27
Copy link
Contributor

@Jonasmortensen Jonasmortensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@arttu-peltonen arttu-peltonen self-assigned this Oct 20, 2021
@arttu-peltonen arttu-peltonen changed the base branch from master to universal/staging October 25, 2021 07:32
@arttu-peltonen arttu-peltonen force-pushed the rpw/fix-urp-debug-smoothness-mode branch from 5e9bb34 to 4e438d8 Compare October 25, 2021 07:55
@arttu-peltonen arttu-peltonen removed the request for review from a team October 25, 2021 07:56
# Conflicts:
#	com.unity.render-pipelines.universal/CHANGELOG.md
#	com.unity.render-pipelines.universal/ShaderLibrary/Debug/Debugging3D.hlsl
@arttu-peltonen
Copy link
Contributor Author

Yamato is green, except for decals failure on URP_Terrain that was introduced in #5961.

@arttu-peltonen arttu-peltonen merged commit f7e8dae into universal/staging Oct 28, 2021
@arttu-peltonen arttu-peltonen deleted the rpw/fix-urp-debug-smoothness-mode branch October 28, 2021 10:26
phi-lira pushed a commit that referenced this pull request Nov 9, 2021
* Fix reflections-with-smoothness debug mode.

* Changelog
@phi-lira phi-lira mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants